I've just returned from a week in Edinburgh. The one big negative is that it is over-run with tatty tourist shops selling cheap souvenirs. Apart from that, there are some great places to visit - it oozes history at every turn - and some very attractive places for walking nearby. I took a bus to Balerno, and walked back along the Water of Leith (about 10 miles), and also visited Rosslyn Chapel, and walked through Rosslyn Glen. I visited the village of Aberdour, which has a church dating from the 12th century, and walked along the Fife Coastal Path to Burntisland.
(I was born in Glasgow, and spent most of my early years there, so have no axe to grind in recommending Edinburgh!)