Not sure about golf club dress codes in USA but most British golf clubs allow shorts provided they are knee length and are worn with knee socks ie kilt hose, so logically a kilt should be acceptable.