Hamish is right. We were there for 7 days, hit just over half of the sites you list, and still felt rushed.
For example, Edinburgh Castle is at least a full day in itself.