Further to Chas' very good comments, I think it would be helpful for us to ask "what is the 'thing' being made?"

I expect a sporran maker to make sporrans. I don't necessarily expect a sporran maker to also be a metal caster, or a leather tanner. So I am perfectly happy with the notion that my sporran maker is acquiring all the metal bits and the leather they use from some other source.

Now, just as with anything else, there will be degrees of quality and other considerations. Is the metal hand cast sterling or pewter made in Sheffield, or is it stamped tin made in Pakistan? And, more importantly, do I trust my sporran maker to be discerning, and have enough pride in their product, to source out the best quality materials at the best price, so that they can have a good end product to bring to market?

So let's say the metal bits were cast in England and the leather was imported from Spain. Metal bits and leather hides are not sporrans. So long as the sporran itself was made in Scotland, I'd be perfectly content to call it made in Scotland. It's the practice of making the complete sporran elsewhere and slipping the D rings onto the back, and calling that "made in Scotland" that I think is dishonest.

To give another comparison, as someone who keeps a small backyard flock of hens, I frequently warn people away from the so-called "Free Range" eggs sold in the supermarkets -- because by law to be called "Free Range" the hens only have to have "access" to the outside. What this effectively means most of the time is that the chickens are kept in a large industrial hen house like most any other agri-business, only with a small hole in the wall for "access" which 99% of the hens never pass through.

As a kiltmaker, the tartan I use is imported from Scotland, where it was woven (and as Rocky has pointed out, the wool itself may have come from Australia). My buckles and straps come from Canada. The silk cloth I use for lining is woven in China. Not sure where my sewing thread is manufactured. But the kilt itself is made in the USA and I label it as such.

I am a kiltmaker -- I'm not a weaver, I don't know how to cast the metal buckles, nor do I tan my own hides to make the leather straps. I make kilts. I don't think anyone expects a kiltmaker to do all of those things.

Likewise, I don't think anyone expects a sporran maker to also be a metal caster, leather tanner, etc. I think most of us assume those elements are coming from elsewhere, even when we see the "made in Scotland" stamp. But I also think it is reasonable that we (the public) should expect the actual product to be made in Scotland, and not some last-minute bobble attached to an essentially already finished product.