Hamish you can buy a photography permit in St Giles for £1.

Most places are fine in the Castle except where there are signs indicating otherwise such as the Honours of Scotland or the National War Memorial Chapel.

It's been a while since I was last inside Holyroodhouse but I seem to recall photography is not permitted inside,