Yes The Royal Mile is loaded with tat shops.

But there are a few places with real Scottish-made things. Here are a couple of them (in 2007, don't know if they're still there)